Sergey Fedorov

Results 939 comments of Sergey Fedorov

@rakshasa It also fails on Darwin `ppc` due to the same issue (it builds, but library is broken). If it used `__atomic*` builtins instead of `__sync*`, that would work fine...

@traversc Thank you for responding! > Which system uses big endian? Solaris? In my case macOS PPC, but there are quite a number of Big-endian systems, including several *BSD and...

MacOS should have `__BIG_ENDIAN__` defined, I believe: https://opensource.apple.com/source/xnu/xnu-1228/libkern/libkern/OSByteOrder.h.auto.html Which is what is used here: https://github.com/traversc/qs/blob/master/src/xxhash/xxhash.h#L1067 Alternatively `__POWERPC__` can be used, which is always Big-endian.

@traversc My thought was that a sample passed in a test file is endian-specific, and that triggered the error. If it is not the case, then endianness handling goes wrong...

> Ah, you could be right that it's the test where the issue is, not the code. > Does the package work otherwise outside of the test? The last time...

@traversc The first test passes (for which I replaced the script; but perhaps it passed originally as well?): ``` R version 4.2.3 (2023-03-15) -- "Shortstop Beagle" Copyright (C) 2023 The...

@traversc Thank you very much! Will test later tonight and update you. P. S. Referring to https://github.com/traversc/qs/commit/f9a244b459289b7416d0e4c3c4ed05225811a229 `-latomic` is not conditional on GCC version in fact. It never gets passed...

@traversc I tried to build from the master. Unfortunately, atomics test does not work: ``` * installing *source* package ‘qs’ ... ** using staged installation checking for pkg-config... /opt/local/bin/pkg-config R...

@traversc Aside of atomics test, everything else works now, tests pass: ``` * using log directory ‘/opt/local/var/macports/build/_opt_PPCRosettaPorts_R_R-qs/R-qs/work/qs-f9a244b459289b7416d0e4c3c4ed05225811a229/qs.Rcheck’ * using R version 4.2.3 (2023-03-15) * using platform: powerpc-apple-darwin10.8.0 (32-bit) * using...

> I think I finally got the detection of GCC correct, see if it works now. Yes, it works now! Thank you.