Sergey Fedorov

Results 1184 comments of Sergey Fedorov

@michaelld When you get a minute, could you please help with merging this? It was ready for non-PPC long back, now PPC also building. This is the last of `folly`...

@reneeotten Yes, right. Thank you. No point to have this hanging in the meanwhile. I will work on PPC, may take time, since it is not high in priority. But...

@emillon It works a bit differently. All ports using `ocaml` PG get default dependencies automatically, unless something is set to be overridden in portfile. I can see that `ocaml-csexp` installs...

@emillon What would be a correct solution? I have been able to build it locally be using vendored copy instead of external lib dependency. However it still failed on Macports’...

> The right way is to remove the vendored directories after unpacking the tarball (in `post-extract` if I understand correctly). `csexp` is packaged separately and has its own tarball -...

> Does your configurator build script delete the vendor directory? I believe this is what it is set to do: https://github.com/ocaml/dune/blob/557a001436beaa3e4424e79b52a81c23b4e75710/dune-configurator.opam#L28 And what I started with was existing Macports portfile...

@rgrinberg Portfile does not set anything to be deleted from the sources. By setting `ocaml.build_type dune` it passes handling of the build to Dune. No custom settings are added for...

@rgrinberg Okay, I will try that and update in a while.

@rgrinberg Sorry for a forgotten topic, it worked, thank you.

@martijnvels @ezbr @mkruskal-google @derekmauro Could someone help me and review this? The current (new) release of `abseil` still builds fine with my patches on PPC.