Patrick Barone

@mikeferguson Makes sense to me. Let me know if you would like me to make any changes and/or split up this PR into multiple PRs.

@mikeferguson Unfortunately, it looks like the majority of the integration tests still use the deprecated map_server CLI and I don't think there is an easy way to port to the...

One alternative could be to make the map_server use rosparams instead of loading a yaml directly. Then the unit tests could manually specify the rosparams in the roslaunch file using...

With the following YAML file in `amcl/test` ``` image: willow-full.pgm resolution: 0.1 origin: [0.0, 0.0, 0.0] occupied_thresh: 0.65 free_thresh: 0.196 negate: 0 ``` I get the following error ... ```...

After a little more investigation `$(find amcl)` does a little bit of magic which allows it to resolve files in any of these directories ... ``` pbarone@pbarone-t460p:~/catkin_ws$ catkin_find amcl /home/pbarone/catkin_ws/devel/include/amcl...

Same ^

Same. Thanks!

One potential solution appears to be patching `has_const_begin_end` and `has_mutable_begin_end` as follows ... ``` template struct has_const_begin_end< T, void_t< decltype(detail::range_begin(std::declval())), decltype(detail::range_end(std::declval())), decltype(detail::range_begin(std::declval()) != detail::range_end(std::declval()))>> // Added : std::true_type {}; template...

@vitaut I think that `FMT_DEPRECATED_OSTREAM` is a bit of a red herring in this case. Even if this is removed and a custom fomatter is provided, the issue is still...

I think that `is_range` is incorrectly returning that `Eigen::Matrix3d` is a range when it in fact not. E.g. https://godbolt.org/z/xbETKd5h1