blacklight_range_limit icon indicating copy to clipboard operation
blacklight_range_limit copied to clipboard

Published 20 hours ago • verified publisher icon projectblacklight

Unknown changed to [Missing]

Open kosarko opened this issue 2 years ago • 2 comments

I've noticed this change (the right is https://github.com/projectblacklight/blacklight_range_limit/commit/0a1df5f07a57f1b5b55d61d0e564c53bd17be6c9 and blacklight 7.25.2 the left v8.1.0 and blacklight 7.22.2) image

Shouldn't the English locale value for key missing be used? https://github.com/projectblacklight/blacklight_range_limit/blob/31ff89a940810666f3e7feb8698b5d731e67717d/config/locales/blacklight_range_limit.en.yml#L8

kosarko avatar Jun 03 '22 14:06 kosarko

Oh, this is actually using blacklight.search.facets.missing. Is blacklight.range_limit.missing even used anywhere?

kosarko avatar Jun 06 '22 12:06 kosarko

It looks like the blacklight.range_limit.missing translation is unused after https://github.com/projectblacklight/blacklight_range_limit/commit/a3fd1d412c999939089e11d4a1ed69e2d31e7672 (8.2.0+)

barmintor avatar Jul 29 '22 16:07 barmintor