Geert Barentsen

Results 166 comments of Geert Barentsen
trafficstars

I'll add that we didn't originally add these links because we didn't know what the urls of the compiled notebooks would be. This issue may best be addressed once the...

@jcsmithhere I think this would be an excellent change! :+1: I wonder if the best way to proceed is to introduce a new `duration` parameter for this, so that we...

I love this :+1: Pre-commit hooks may scare some people, so we can focus on encouraging users to run `make black` in the repository before commit.

Thank you for opening this issue! 1. Agreed, this is a bug! It looks like line 57 in `io/cdips.py` incorrectly sets `time_format='btjd'`. 2. There is no strict rule as to...

Thanks for the input both! :+1: The intention of the `lc.meta['LABEL']` entry (also accessible via `lc.label`) is to provide a user-friendly string to be show in the legend of plots...

Agreed! `lc.normalize()` could take an optional `column` argument. Note: if a user wants to work with `SAP_FLUX`, my recommendation is to use ```python lc = lk.read(filename, flux_column='sap_flux')` ``` or ```python...

Right! I think adding a `column` parameter to `lc.normalize` could be a useful enhancement, e.g. we also added `lc.plot(column=...)`, but I don't think it is necessary to go ahead with...

This PR doesn't pass the tests yet, in part because the KEPSEISMIC data products at MAST appear to have `sequence_number=17` (i.e. `quarter=17`) set in the Portal API data, which seems...

Thank you for raising this unresolved issue! 👍 Note: right now we implement `stitch()` by calling `astropy.table.vstack()`, i.e.: https://github.com/lightkurve/lightkurve/blob/fe348653db47c4ade5a7a105b134c12671df7d34/src/lightkurve/collections.py#L223 By using `metadata_conflicts="silent"`, we indeed pick a single meta data value...

@JonahDG Thank you for reporting this issue! I'll investigate this as soon as time allows.