Geert Barentsen

Results 166 comments of Geert Barentsen
trafficstars

For completeness, I'll add that we originally always performed a simple cone search. This frequently caused confusion in the case of overlapping targets, where users would sometimes request "target X"...

Thank you for the suggestion @ColinLittlefield! :+1: I support the idea of making the catalog shown by `interact_sky` a configurable parameter! Is there a specific date by which this feature...

@ColinLittlefield Awesome! I plan on adding this feature for you before the end of the month. Please ping me if you don't hear back by then. (Do let me know...

Good catch! Returning phase in units of days is an intentional change in Lightkurve v2.x. With this change, the `LightCurve.fold()` method now matches the exact behavior and arguments of the...

Only if it's an easy change in interact_bls! Not the end of the world if the interactive room used normalized phase by default.

This is awesome! Thank you for exploring this!! :+1: Here are four quick items of feedback: --- **Item 1**: I see that this PR proposes to use a custom `SearchResultCache._memoize()`...

Thanks for reporting this issue @keatonb! It is true that sigma clipping isn't very complicated, but even easy features can be very time-consuming to document, test, and maintain in a...

> when lightkurve calls [sigma_clip()](https://docs.astropy.org/en/stable/api/astropy.stats.sigma_clip.html), we explicitly pass cenfunc and stdfunc parameters to ask it to use numpy version I like this!

> It's a bit off topic, but it'd be great if you could share some of the motivation of using MaskedQuantity over Quantity in lightkurve context. The reason we encounter...

I think this is a good idea! :+1: