Shrey Banga

Results 20 comments of Shrey Banga

Interesting, I use this library to figure out the terminal size in a cross platform manner: https://github.com/sindresorhus/term-size/blob/main/index.js. From reading the implementation, I'm guessing it's seeing a different value for `process.platform`...

Yes this is something Phabricator does much better. I think modifying the diff algorithm itself requires more information than we have in this tool (since it's just parsing the output...

Ah I've run into something like this very occasionally on iTerm2/xterm but haven't been able to repro consistently enough to find a fix. For me, it only occurs when I've...

Oh I see, thanks. If I can repro consistently that would actually be really useful, so I'll keep this open. Does it break when you show this particular diff: https://github.com/fernandocanizo/my-env/commit/4434b1010d20fe8688eb324d0f8b979329c2dda4....

Oof this happens to me too and annoyingly doesn’t reproduce on the same input twice. Are you able to repro it consistently?

Hey linjie! Yeah I went down the same path in https://github.com/shikijs/shiki/pull/151, which should speed it up a little (~30% for me). Also see https://github.com/banga/git-split-diffs#performance. > Provide CLI flag to turn...

Ohh got it. I haven’t, will look into it. It’s a little tricky because buffering will delay the initial render which is when the delay is most noticeable, but it’s...

Makes sense. The reason everything has a background is because I added support for alpha in colors, so that you could say e.g. line deletions are `ff000022` which adds a...