git-split-diffs icon indicating copy to clipboard operation
git-split-diffs copied to clipboard

Needs theme with no background color

Open Cretezy opened this issue 3 years ago • 5 comments

I use a black background in my terminal, and the "dark" themes aren't really enough. Either having a black theme or one without background color (meaning using the terminal's background) would be ideal.

Great project!

Cretezy avatar May 02 '21 00:05 Cretezy

Second this. I use a terminal with a translucent background:

Screen Shot 2021-05-01 at 8 26 09 PM

however, git-split-diffs adds an opaque background behind every character on the screen:

Screen Shot 2021-05-01 at 8 28 28 PM

It would be great if there were an option to render a theme without any background color on the non-highlighted lines (obviously, the lines highlighted as added or removed need to have a background color)

controversial avatar May 02 '21 00:05 controversial

Makes sense. The reason everything has a background is because I added support for alpha in colors, so that you could say e.g. line deletions are ff000022 which adds a reddish tinge to the background. This is especially useful if you have multiple layers like for highlighting inline changes.

Anyway, will think of a fix. Would you rather have a way to unset background colors in existing themes, or just have a separate theme without backgrounds? I'm guessing the former would be better so you can use any theme

banga avatar May 02 '21 00:05 banga

Alternatively, a way to point to a custom .json theme file, so everyone can be happy 😃

Cretezy avatar May 02 '21 01:05 Cretezy

Oh yeah that might be better. You can hackishly do that right now by making theme-name a relative path, but there should be a better way

banga avatar May 02 '21 01:05 banga

I hacked together a quick fix in #8!

controversial avatar May 02 '21 01:05 controversial