Paulus Schoutsen

Results 421 comments of Paulus Schoutsen

Yep, all diagnostics require a test.

We currently only make a connection to check the chip type after we ask for name and Wi-Fi. Since it's a small use case and we can assume that users...

The problem with adding it to Improv is that Improv is only available on upgrade.

Changes like these should be combined with test sentences that are using them.

Don't forget to add tests.

@scorpoon can you take a look ?

@Scorpoon can you please review this PR.

You can use the [`new_install_improv_wait_time`](https://esphome.github.io/esp-web-tools/#manifest) option to extend the delay on how long it will wait for the Improv response.