core icon indicating copy to clipboard operation
core copied to clipboard

Add diagnostics to VeSync

Open chuckdeal97 opened this issue 2 years ago • 7 comments

Proposed change

Add the diagnostics feature to the VeSync integration

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [x] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] The code has been formatted using Black (black --fast homeassistant tests)
  • [x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

chuckdeal97 avatar Jan 21 '23 19:01 chuckdeal97

Hey there @markperdue, @webdjoe, @thegardenmonkey, mind taking a look at this pull request as it has been labeled with an integration (vesync) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of vesync can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign vesync Removes the current integration label and assignees on the issue, add the integration domain after the command.

home-assistant[bot] avatar Jan 21 '23 19:01 home-assistant[bot]

We usually require tests for diagnostics so we can see what data is being sent to check for privacy concerns.

At the very least please include a sample dump

epenet avatar Jan 21 '23 19:01 epenet

Yep, all diagnostics require a test.

balloob avatar Jan 22 '23 04:01 balloob

Marked as draft, please set the PR to "ready for review" when you've added tests @chuckdeal97 👍

emontnemery avatar Jan 24 '23 18:01 emontnemery

We usually require tests for diagnostics so we can see what data is being sent to check for privacy concerns.

At the very least please include a sample dump

Not a problem, I'll work on it over the next few days. Thanks for the feedback.

chuckdeal97 avatar Jan 25 '23 03:01 chuckdeal97

@balloob, thanks for all of the feedback. I believe that I've addressed everything.

chuckdeal97 avatar Feb 25 '23 18:02 chuckdeal97

@balloob, I've gotten the last set of feedback corrected. Which one of us is supposed to resolve the conversations above?

chuckdeal97 avatar Feb 27 '23 00:02 chuckdeal97

phew! ok @balloob, what's next?

chuckdeal97 avatar Mar 01 '23 00:03 chuckdeal97