Add diagnostics to VeSync
Proposed change
Add the diagnostics feature to the VeSync integration
Type of change
- [ ] Dependency upgrade
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New integration (thank you!)
- [x] New feature (which adds functionality to an existing integration)
- [ ] Deprecation (breaking change to happen in the future)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [ ] Code quality improvements to existing code or addition of tests
Additional information
- This PR fixes or closes issue: fixes #
- This PR is related to issue:
- Link to documentation pull request:
Checklist
- [x] The code change is tested and works locally.
- [x] Local tests pass. Your PR cannot be merged unless tests pass
- [x] There is no commented out code in this PR.
- [x] I have followed the development checklist
- [x] The code has been formatted using Black (
black --fast homeassistant tests) - [x] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [ ] Documentation added/updated for www.home-assistant.io
If the code communicates with devices, web services, or third-party tools:
- [ ] The manifest file has all fields filled out correctly.
Updated and included derived files by running:python3 -m script.hassfest. - [ ] New or updated dependencies have been added to
requirements_all.txt.
Updated by runningpython3 -m script.gen_requirements_all. - [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
- [ ] Untested files have been added to
.coveragerc.
To help with the load of incoming pull requests:
- [ ] I have reviewed two other open pull requests in this repository.
Hey there @markperdue, @webdjoe, @thegardenmonkey, mind taking a look at this pull request as it has been labeled with an integration (vesync) you are listed as a code owner for? Thanks!
Code owner commands
Code owners of vesync can trigger bot actions by commenting:
@home-assistant closeCloses the issue.@home-assistant rename Awesome new titleChange the title of the issue.@home-assistant reopenReopen the issue.@home-assistant unassign vesyncRemoves the current integration label and assignees on the issue, add the integration domain after the command.
We usually require tests for diagnostics so we can see what data is being sent to check for privacy concerns.
At the very least please include a sample dump
Yep, all diagnostics require a test.
Marked as draft, please set the PR to "ready for review" when you've added tests @chuckdeal97 👍
We usually require tests for diagnostics so we can see what data is being sent to check for privacy concerns.
At the very least please include a sample dump
Not a problem, I'll work on it over the next few days. Thanks for the feedback.
@balloob, thanks for all of the feedback. I believe that I've addressed everything.
@balloob, I've gotten the last set of feedback corrected. Which one of us is supposed to resolve the conversations above?
phew! ok @balloob, what's next?