core icon indicating copy to clipboard operation
core copied to clipboard

Update pycsspeechtts to allows Microsoft TTS to use XML tags to customize voice

Open joshmwilliams opened this issue 3 years ago • 9 comments

Proposed change

This change is a dependency bump for Microsoft TTS to update pycsspeechtts to a newer version that allows use of inline XML tags to increase flexibility of voice synthesis.

Type of change

  • [X] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #65221
  • This PR is related to issue: #65221
  • Link to documentation pull request:

Checklist

  • [ ] The code change is tested and works locally.
  • [ ] Local tests pass. Your PR cannot be merged unless tests pass
  • [ ] There is no commented out code in this PR.
  • [ ] I have followed the development checklist
  • [ ] The code has been formatted using Black (black --fast homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • [ ] No score or internal
  • [ ] 🥈 Silver
  • [ ] 🥇 Gold
  • [ ] 🏆 Platinum

To help with the load of incoming pull requests:

joshmwilliams avatar Jan 30 '22 01:01 joshmwilliams

Hi @joshmwilliams,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

homeassistant avatar Jan 30 '22 01:01 homeassistant

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar Mar 01 '22 02:03 github-actions[bot]

Does this change allow the use of Microsoft's 'Speaking Styles' such as Angry/Cheerful/Sad? Is there anything else that needs done to move this forward?

iridris avatar Mar 05 '22 12:03 iridris

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar Jun 03 '22 13:06 github-actions[bot]

@joshmwilliams Is this still a viable PR? It would be handy to be able to use Microsoft's alternate speaking styles (assuming this PR provides the ability to set those).

iridris avatar Jun 06 '22 12:06 iridris

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar Sep 07 '22 03:09 github-actions[bot]

Commenting to keep the stalebot at bay. Is there anything I can do to assist with getting this PR finished up?

iridris avatar Sep 14 '22 01:09 iridris

Please make this happen. I need the 'styles' option.

EroticBananaz avatar Sep 20 '22 10:09 EroticBananaz

I was digging deeper on this. I found that this pull request is bumping up the version number of the underlying library. However, the change to the underlying library that added the style support is merged to the repository but hasn't had a version numbered release since that merge. I've posted in that repository asking for a version bump but haven't gotten a response yet.

https://github.com/jeroenterheerdt/pycsspeechtts/issues/14

iridris avatar Sep 21 '22 11:09 iridris

Closing this as still in draft.

balloob avatar Nov 27 '22 20:11 balloob