baimont

Results 7 comments of baimont

/ocabot migration account_fiscal_year

> Not an expert in accounting but here is my review, nothing blocking. Hi @robinkeunen, thanks for your review! I adapted the code or answered to your comments.

**technical analysis** What does the stack trace say? `Error: While parsing modifiers for div: for modifier "invisible": Unknown field state in domain` in partner_tier_validation, partner_form_tier adds state field on partner...

> @sbejaoui The dependency was merged, please rebase this PR. hi @sbejaoui +1 let's merge this at the oca days and we'll be able to merge this one too https://github.com/OCA/contract/pull/1246

> Would be nice to rebase this on top of the v16 version of the module. Hi @sbejaoui v17 even

> Hello, #1212 is merged, can you rebase? hi @bjouini-acsone can you rebase so that we merge this at the oca days? thanks!