OCA
[18.0][MIG] contract_sale_payment_mode: Migration to 18.0
@bjouini-acsone tests are failing. Please also run tests and ensure they pass before marking the PR as ready for review
@bjouini-acsone tests are failing. Please also run tests and ensure they pass before marking the PR as ready for review
@marielejeune the test it works fine with no issue in this module the probelm is in the module :contract_payment_mode with the compute function in contract : _compute_payment_mode_id
i will fix the function there
@bjouini-acsone tests are failing. Please also run tests and ensure they pass before marking the PR as ready for review
@marielejeune the test it works fine with no issue in this module the probelm is in the module :contract_payment_mode with the compute function in contract : _compute_payment_mode_id
i will fix the function there
Please ping the author of the migration in his PR, with a detailed explanation of the problem, if you think the error is in his module.
@bjouini-acsone What are you doing? This PR depends on the migration of addon contract_payment_mode. A PR is already opened here: https://github.com/OCA/contract/pull/1212
If you consider there is an error in the migration, you must review and comment this original PR, not creating another branch on the acsone fork, otherwise these changes will never be merged in the OCA repo.
But your PR must still depend on a PR on the OCA repo, nothing private.
Hello, https://github.com/OCA/contract/pull/1212 is merged, can you rebase?
Hello, #1212 is merged, can you rebase?
hi @bjouini-acsone can you rebase so that we merge this at the oca days? thanks!
@bjouini-acsone Thanks for the rebase, however the tests are failling. Can you check?
What a great day to merge this nice PR. Let's do it! Prepared branch 18.0-ocabot-merge-pr-1233-by-sbejaoui-bump-nobump, awaiting test results.
Congratulations, your PR was merged at bf8fd8cb27bdbe67427e2130c17d84e0ad43f693. Thanks a lot for contributing to OCA. ❤️