Badrish Chandramouli

Results 141 comments of Badrish Chandramouli
trafficstars

> > Instead of modifying `main/GarnetServer`, can we perhaps add a new `main/GarnetHost` (open to other namings) so that the existing straightforward server is not affected or have to carry...

Closing as https://github.com/microsoft/garnet/pull/614 incorporates this concept.

/home/runner/work/garnet/garnet/libs/client/GarnetClientAPI/GarnetClientListCommands.cs(44,1): error WHITESPACE: Fix whitespace formatting. Replace 17 characters with '\n\s\s\s\s\s\s\s\s'. [/home/runner/work/garnet/garnet/libs/client/Garnet.client.csproj] /home/runner/work/garnet/garnet/libs/client/GarnetClientAPI/GarnetClientListCommands.cs(46,1): error WHITESPACE: Fix whitespace formatting. Replace 17 characters with '\n\s\s\s\s\s\s\s\s'. [/home/runner/work/garnet/garnet/libs/client/Garnet.client.csproj] /home/runner/work/garnet/garnet/libs/client/GarnetClientAPI/GarnetClientListCommands.cs(129,2): error FINALNEWLINE: Fix final newline....

We will review it in the next day. Also note: > Contributor License Agreement is not agreed yet.

It would be a great idea to support OpenTelemetry on the server side, and contributions in this space are highly encouraged! Not only is this generally useful, but when used...

We are removing support for .NET 6 here: https://github.com/microsoft/garnet/pull/580 Hope to see a contribution in this space!

Source generators in my experience create challenges with debugging and stability across platforms. We have to consider whether this will help us in critical paths. Adding it for non-critical regions...

Makes sense. At the end of the day, the open question is (1) will this work seamlessly on all platforms; (2) are enums used in this way anywhere critical in...

> > I think the source generator should target NS 2.0, not .NET 8. > > This could explain why using the dotnet cli and VS doesn't. I'll test using...

Closing as we have addressed this for the existing enums without using source generators, for now. Thank you!