garnet icon indicating copy to clipboard operation
garnet copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

Add LPUSH & RPUSH command API wrappers to GarnetClient

Open hishamco opened this issue 1 year ago • 7 comments

/cc badrishc

hishamco avatar May 14 '24 00:05 hishamco

Is the file-scope namespace the matter here?!!

hishamco avatar May 14 '24 00:05 hishamco

/home/runner/work/garnet/garnet/libs/client/GarnetClientAPI/GarnetClientListCommands.cs(44,1): error WHITESPACE: Fix whitespace formatting. Replace 17 characters with '\n\s\s\s\s\s\s\s\s'. [/home/runner/work/garnet/garnet/libs/client/Garnet.client.csproj] /home/runner/work/garnet/garnet/libs/client/GarnetClientAPI/GarnetClientListCommands.cs(46,1): error WHITESPACE: Fix whitespace formatting. Replace 17 characters with '\n\s\s\s\s\s\s\s\s'. [/home/runner/work/garnet/garnet/libs/client/Garnet.client.csproj] /home/runner/work/garnet/garnet/libs/client/GarnetClientAPI/GarnetClientListCommands.cs(129,2): error FINALNEWLINE: Fix final newline. Delete 1 characters. [/home/runner/work/garnet/garnet/libs/client/Garnet.client.csproj] /home/runner/work/garnet/garnet/test/Garnet.test/RespListGarnetClientTests.cs(139,2): error FINALNEWLINE: Fix final newline. Delete 1 characters. [/home/runner/work/garnet/garnet/test/Garnet.test/Garnet.test.csproj]

badrishc avatar May 14 '24 01:05 badrishc

Why you code style don't complain during the build in VS?

hishamco avatar May 14 '24 01:05 hishamco

@badrishc is the process takes long to review, because I need to update to main whenever a new PR is merged

hishamco avatar May 14 '24 20:05 hishamco

We will review it in the next day. Also note:

Contributor License Agreement is not agreed yet.

badrishc avatar May 15 '24 18:05 badrishc

@microsoft-github-policy-service agree

hishamco avatar May 15 '24 19:05 hishamco

Seems the review takes so long :)

hishamco avatar May 20 '24 12:05 hishamco