Badrish Chandramouli

Results 138 comments of Badrish Chandramouli
trafficstars

@vazois @lmaas - any additional comments on this PR? Is it ready for merge?

Interesting stuff! Glad to see you are making progress here. :)

@nicholih and @babykart - thanks! @nicholih and others - can you start with this chart and see if it can be made into a PR?

> @badrishc I can do a PR (?). I think that a good path to store the helm chart source in a project repository could be `charts/garnet` or if you...

> Hey @badrish ***@***.***>, I submitted a PR for an updated helm chart in the garnet repo. > […](#) > ________________________________ From: Badrish Chandramouli ***@***.***> Sent: Sunday, June 2, 2024...

> MakeUpperCase is potentially dangerous. It has no length limit so it'll keep scanning potentially out of bounds and output the client anything that it got to MakeUpperCase does have...

Yes, we are definitely open to accepting pull requests in this space. Thanks, and look forward to it!

These can be added at https://github.com/microsoft/garnet/tree/main/libs/client/GarnetClientAPI - you will see there are already files for different API categories, such as Sorted Set. You would add the new ones similarly.

It was just a stylistic choice. We can leave it as `Garnet.client` - it is fine as long as our format style does not complain.