backwardsEric

Without more details about the original report, it isn't clear if it has the same explanation as dburgener's. I'd still close this and let any new report get its own...

According to the readme, it is by design. In the section about optional keys for "with" the readme says: "target_committish - Commitish value that determines where the Git tag is...

The current logic in the if statement is correct and square_know_pile() will have the side effect of creating obj->known if it is NULL. The potential issue is if the ~~compiler~~...

Perhaps replacing square_know_pile() there with see_object(player, obj) would avoid the code analysis warning and any concerns about obj->known not being reloaded since it would be clear that the contents of...

This needs some more work. It could be exploited by a blackguard to move without triggering bloodlust checks. Repeating the last command will only work with pathfinding if the pathfinding...

The forced push removes the possibility of exploiting pathfinding to avoid bloodlust, changes how the last command is remembered so repeating pathfinding will work reliably, and makes the command queue...

Andres6936 added the initial support for CMake in https://github.com/angband/angband/pull/4437 . There was some agitation against autoconf and for CMake on the forum (an example thread is here, http://angband.oook.cz/forum/showthread.php?t=9984&highlight=cmake ), but...

My guess is that a single Makefile will have to work very hard to satisfy most of the competing demands for what the build system should do. A single makefile...

Those two are the things I know of that are unresolved with respect to this pull request.

The accepted changes from https://github.com/angband/angband/pull/5944 largely supersede this pull request. Good aspects of this pull request which are not included are: 1. the use of an absolute path to the...