Clemens Backes

Results 31 comments of Clemens Backes

Seems like this is the fix: ``` diff --git a/src/wasm-delegations-fields.def b/src/wasm-delegations-fields.def index 3d7504c60..422bb521c 100644 --- a/src/wasm-delegations-fields.def +++ b/src/wasm-delegations-fields.def @@ -461,12 +461,16 @@ switch (DELEGATE_ID) { } case Expression::Id::MemorySizeId: { DELEGATE_START(MemorySize);...

> > Can you please file bugs at http://crbug.com/v8/new? > > I plan to isolate test cases as part of the aforementioned blog post. I will then be able to...

We plan to finish Liftoff support next quarter (Q3 2020). It should be ready to be staged when this is done. Once it is staged, you can enable it via...

I didn't hit this yet, but the V8 implementation is not complete yet. Also, we currently still only allow up to 4GB memories, even if you use 64 bit for...

> My understanding is that this would not but much work from the implementation side. @backes and @eqrion perhaps you could confirm? > > (To be clear this would _not_...

I didn't spot any non-convertible modules with `assert_invalid`, I just noticed that this produces the same output. I would have expected the wast->JS conversion to fail if `assert_invalid` is used...

Ack, let's ignore the `assert_invalid` case. How much work would it be to skip the `assert_malformed` tests in the JS generation? We currently execute 2869 `assert_malformed` tests in every test...

The original motivation for filing this was that I was confused that we didn't fail the test quoted above (V8 was missing a validation and produced a trap at runtime...

Note: After this change, cpplint will find a few violation in the v8 code base, which I am fixing in this CL: https://crrev.com/c/1367751

FYI: The V8 change to fix the new warnings landed now: https://crrev.com/c/1367751