Babneet Singh

Results 178 comments of Babneet Singh

> @babsingh do you see any reason for the Continuation to be pinned in the test code? Paths, where `ownedMonitorCount` is incremented and decremented, may have an inconsistency. PPC has...

Test: https://github.com/ibmruntimes/openj9-openjdk-jdk19/tree/openj9/test/hotspot/jtreg/serviceability/jvmti/stress/ThreadLocalStorage/SetGetThreadLocalStorageStressTest The above test covers virtual threads, platform threads, event callbacks, event notification modes and thread local storage. It should succeed with this PR.

This PR should fix the following JVMTI functions in JDK19: `SetThreadLocalStorage`, `GetThreadLocalStorage`, `SetEventCallbacks`, `SetEventNotificationMode` and JVMTI event callbacks (`J9JVMTIThreadData->threadEventEnable`). My preference will be to have these functions fully working in...

Does the following test pass: https://github.com/ibmruntimes/openj9-openjdk-jdk19/tree/openj9/test/hotspot/jtreg/serviceability/jvmti/stress/ThreadLocalStorage/SetGetThreadLocalStorageStressTest?

Also, can you point me to the code that sets `targetThread = currentThread` for a yielded virtual thread?

On leave till 31 Aug 22; won't be able to complete the review. Delegating the review to either @tajila or @gacholio or @hangshao0.

@EricYangIBM The commits can be squashed. @tajila These changes should work fine. But, still doubtful about the memory allocated for `threads` and `groups` arrays which are returned from this method...

> This is not going to return vthreads correct? Vthreads will not be returned. See ref below. @EricYangIBM Can you add a comment in code and open an issue regarding...

LGTM. The commits need to be squashed before the PR builds are launched.

jenkins compile win jdk19,jdk17