Babneet Singh

Results 178 comments of Babneet Singh

The test passes locally. We can re-enable the test: - JDK19: https://github.com/adoptium/aqa-tests/blob/26b24753e1587b474180af2070bdff4759509b27/openjdk/excludes/ProblemList_openjdk19-openj9.txt#L442 - JDK20: https://github.com/adoptium/aqa-tests/blob/26b24753e1587b474180af2070bdff4759509b27/openjdk/excludes/ProblemList_openjdk20-openj9.txt#L483

Disabled again via https://github.com/adoptium/aqa-tests/pull/4120. The failure is intermittent. More investigation is required. The timeout may happen due to the GC race condition which was mentioned last week. fyi @LinHu2016. The...

re https://github.com/eclipse-openj9/openj9/issues/15181#issuecomment-1277942198: My preference: ``` // This syntax is short and easy to type. The description can specify verbose details. Option 2: !vthreads // Although long, this syntax will support...

re https://github.com/eclipse-openj9/openj9/issues/15181#issuecomment-1277951518: All our useful. The first three are critical, which are currently being implemented. Others are a future TODO. Consideration: there can be a million virtual threads. Printing any...

re https://github.com/eclipse-openj9/openj9/issues/15181#issuecomment-1278033949: - `ELS` -> `EntryLocalStorage`. Instead of the abbreviation, a more verbose naming is better for readability. - Can default methods be used in the interface to avoid duplication?

@hangshao0 The test needs to be re-enabled, and then the `test excluded` tag should be removed. - JDK19: https://github.com/adoptium/aqa-tests/blob/a74405ca1262c4e50ea0a88e9cb27ade2dd60179/openjdk/excludes/ProblemList_openjdk19-openj9.txt#L443 - JDK20: https://github.com/adoptium/aqa-tests/blob/a74405ca1262c4e50ea0a88e9cb27ade2dd60179/openjdk/excludes/ProblemList_openjdk20-openj9.txt#L483

Closing. `StructuredTaskScopeTest` passes now. No failures seen in https://openj9-jenkins.osuosl.org/job/Grinder/2348/ (100x grinder). It has been re-enabled for JDK20; see https://github.com/adoptium/aqa-tests/blob/master/openjdk/excludes/ProblemList_openjdk20-openj9.txt; the exclude has been removed.

~Now, this failure is also seen in a certification test. So, it will need to be fixed for Java 21.~ I misinterpreted the behaviour highlighted in https://github.com/eclipse-openj9/openj9/pull/17938 with the failure...

For JDK19+, we implemented lazy allocation of TLS array and thread-data in https://github.com/eclipse-openj9/openj9/pull/15541. **Correction:** This does not include the first solution from https://github.com/eclipse-openj9/openj9/issues/15853#issuecomment-1474958089 which mentions of delaying TLS key creation....