Subhraman Sarkar
Subhraman Sarkar
@stevecotton can this be merged, or you'd suggest waiting some more?
> Where do we stand here? Looks like it's pretty close to merging - if not already there - but I don't know if there are still outstanding concerns. Waiting...
> Looking at this again, it doesn’t seem great that some labels use colons and others do not. Personally, I’d say don’t merge. I think I agree that inconsistent colons...
@stevecotton I can move this entirely into the `wesnoth` textdomain and remove the trailing spaces.
> At least for the moment, my feeling is to take the commit that uses the existing unit_alignment data, but drop the commit with the string changes. I've dropped that...
Was doing some testing on this on my local branch and noticed the following issues: - [ ] Text rendering does not work. Either causes crash or renders boxes, an...
~~I added a couple of wrong commits by mistake. Will update.~~ Updated, sorry for the force-pushes.
44e7a4b24078947759d3af6daff13efa064b0f44 might also be able to solve https://github.com/wesnoth/wesnoth/issues/4817.
> I assume the escape key still skips too? Yes.
@Vultraz How can I refresh the drawing in the middle of `display_part()`? `queue_redraw()` doesn't work. It now has the small bug that if someone resizes the window in the middle...