Bartłomiej Chmiel

Results 21 comments of Bartłomiej Chmiel

Thank you for the review. I'd fixed several issues. Tests with `-fno-inline` option fail, thus I need to redesign my approach. I'll open PR once ready.

The `-fno-inline` problems has been fixed by implementing assertctl checks via module ports `__Vassert_disabled` and `__Vassert_port` which are forwarded from parents to children. This is done only for modules that...

The assertcontrol implementation for both classes and interfaces appeared to be quite troublesome. Therefore, to reduce size of this PR I added unsup checks for both scenarios leaving the possibility...

Since argumentless assert control tasks does not need assertion propagation (global `assertOn` is used regardless of assert control task location). Therefore, I decided to remove assert control task propagation required...

Marking as WIP, since it requires reworking annotations. Moreover, I noticed that the script `clang_check_attributes` is not stable. I'll reopen it once ready.

@wsnyder I added required annotations for functions that are used in V3VariableOrder to make `clang_check_attributes` pass. I also extracted Ast modifications outside MT phase so now the whole phase is...

> To be honest, I preferred the more limited parallelization as it seemed closer to "obviously correct". @wsnyder I think, this stage is a bit more clean now, since variable...

Tested on `asap7` PDK. Results (in the regression test suite): [aes_annealing.ok](https://github.com/The-OpenROAD-Project/OpenROAD/blob/089d41d806190e95da38bac29965b37bcd95fd4c/src/rmp/test/aes_annealing.ok#L161) [aes_genetic.ok](https://github.com/The-OpenROAD-Project/OpenROAD/pull/8908/files#diff-fd9ae51ed47beba73a0556f391ceff9fd151e679c339c9c640c012791681b9c1R166) Slacks are positive, the higher the better. I'll adjust the description.

The only errors I'm getting right now are related to ABC imports. For instance, importing header such as `map/if/if.h` causes include cycle warning (which is there as it includes `map/if/acd/ac_wrapper.h`...

@maliberty The `if.h` header is required to be able to construct `If_Par_t` struct with custom parameters (defined there). This header throws two warnings: - `Wredundant-decls` (for repeated externs) - `Wunused-but-set-variable`...