Ayende Rahien

You need to keep reading until `read()` returns a zero, that is the only scenario where you can be sure that the file is done. Something like this: ``` loop...

I noticed that you have `encrypt_next` vs. `encrypt_last`, you should probably just call `encrypt_next` always, and pass `encrypt_last` with empty buffer.

If you need to make the distinction between next & last, read to the buffer until it is full, even if you get partial read. And only stop if you...

I think that it is far more common to have an IP there than an actual invalid hostname. Just having an error that talks about IPs are not allowed would...

I actually run into that when using the system to demo Entity Framework Profiler. I used that to showcase how I can find those sort of issues. Thanks for providing...

The idea is that this delegate that we inject allow us to verify that the scripts isn't doing BAD THINGS. See fuller discussion of this and the implications of what...

@paulbartrum We actually tested a bunch of other stuff, including injecting our code on every branch instruction, but that seemed too intrusive. I can't think of a way that this...

Note that in general, this is probably a bad idea to just add that. You want to stream the results, which already support async enumeration, see: ``` public static Task...

See the code above, that gives you the right behavior. In general, `AsAsyncEnumerable` for RavenDB queries is not a good idea. You want to do that on a _streaming_ query,...

Some of the tests are failing because the index we emit is using: ``` docs.Cameras.Select(camera => new { Manufacturer = camera.manufacturer, Model = camera.model, Cost = camera.cost, DateOfListing = camera.dateOfListing,...