Shuhei Kadowaki

Results 361 comments of Shuhei Kadowaki

It's really nice to have tests passing on the stable version!

We have `ir_to_codeinf!`, which converts back `IRCode` to `CodeInfo`, although it does preserve post-opt IR elements like `PhiNode`. AFAIR there is no utilities like an inverse of `slot2reg`. We would...

This looks very reasonable. Thanks so much for tackling this and sorry for being very late to give a review.

Sorry for being late to reply, but is this still issue for you?

This issue is more related to JET itself rather than the regression in Julia. That’s because JET’s precompilation is intentionally disabled in v1.11 and later (https://github.com/aviatesk/JET.jl/blob/4188f9b98b24ce78ad38cd53abe6496a947633d4/src/JET.jl#L1211). The reason for this...

This should be fixed on Julia v1.12, where JET's precompilation is supported.

Afraid to nudge, but can we get this PR merged? I've been using the build from this branch for a few days, and I think the signature help has generally...

I'm trying to finish the implementation at #33199.

> @aviatesk any idea why the effects tests are failing? I guess this issue has been resolved by implementing the effects modeling for the new builtin?

Instead of simply inserting `finalize`, I changed the approach to inline the finalizer body and cancel the finalizer registration (by preparing new builtin `Core._cancel_finalizer`). It looks like this PR is...