Aubrey Wahl
Aubrey Wahl
I've been [experimenting](https://github.com/commaai/openpilot/pull/35082) with adding CAN ignition coverage to test_models.py In the experiment, we check every rx to ensure that only [gm|mazda|rivian|tesla] see CAN ignition. I.e.: ```diff diff --git a/selfdrive/car/tests/test_models.py...
I spent some time trying to break things down into smaller PRs, but now I'm not so sure how feasible thi will be because I'm struggling with the MISRA checks....
@robbederks Here's where we stand: - I was able to make do the refactor without https://github.com/commaai/panda/pull/2181, but it did require changes to opendbc. We are forced to address the namespace...
Sounds good. Also, I think there's one opportunity for a pre-factor in panda: refactor the various "config"/definition headers. This would basically be a no-op change to clarify the config dependency...
@robbederks prefactor PR is ready for you https://github.com/commaai/panda/pull/2180
@robbederks some updates: I have made the changes you requested locally, and it seems to work, but a new change merged to opendbc has introduced a blocker. https://github.com/commaai/opendbc/pull/2088 just broke...
@robbederks OK I think I've finally figured out how to make this CLEAN 🍋 ✨ 1. https://github.com/commaai/opendbc/pull/2076 minimal no-op refactor of opendbc 2. https://github.com/commaai/panda/pull/2188 3. https://github.com/commaai/panda/pull/2189 4. https://github.com/commaai/panda/pull/2186 delete duplicated...
FWIW: I tried for a good while to get hardware decoding to happen with v4l2. I could not quite make it work. I tried doing something similar to v4l_encoder.cc, but...