Aubrey Wahl

Results 18 comments of Aubrey Wahl

dang this issue really caused me a lot of headache :/ +1 for making that more obvious in the docs

👍yep will try to have a look in the next couple weeks On Fri, May 18, 2018, 1:32 AM Mike Buhot wrote: > Is there a way to configure #swagger...

yeah it was definitely cool! discussion was great. would be really cool if we could get people from core react native team on there

@robbederks I think for this work, we will need source-and-header-ify https://github.com/commaai/opendbc/tree/master/opendbc/safety, since we would need to #include those headers here. I got build working locally by patching safety.h & co....

Aw crud my bad. I started working on this before it was locked–didn't realize what was going on 😞 .

I'm in! I will draft a more detailed plan for breaking the change into smaller PRs today. I did the hard part already which is getting the code to compile....

@robbederks I'm prototyping my merge plan and am a bit behind. I will follow-up on the merge plan with a clear head tomorrow morning.

> why is this needed exactly? I did it this way because when I first started working this, it was the only way to unambiguously break the circular dependency chain–otherwise...

Closing in favor of https://github.com/commaai/panda/pull/2185

@sshane I humbly propose https://github.com/commaai/opendbc/pull/2131 Lemme know what you think!