Joe Atzberger
Joe Atzberger
Currently we have the controller cache grant tokens per service in the user's session. When tokens expire or are revoked, the controller does not know how to handle it, because...
In .internal_test_app, `bundle exec rake db:migrate:status` gives: ``` Errno::ENOENT: No such file or directory @ dir_initialize - **/repos/browse-everything/.internal_test_app/db/migrate** ``` Interestingly, `db:migrate` runs fine, but we might want to generate an...
`BrowseEverything::Driver::Base` has stub methods returning defaults. Some of those are fine, like maybe `validate_config()` doesn't need to be implemented in each concrete child class. But `contents()` and `connect()` **must** be...
This is basically a "host your own dropbox" integration platform. According to Simon Fraser University, (Canadian) national and provincial legislation inhibits the adoption of dropbox, box, google drive and other...
Protected method `find_with_ids` is only invoked once in this codebase and its method signature and behavior are confused: https://github.com/samvera/active_fedora/blob/master/lib/active_fedora/relation/finder_methods.rb#L224-L239 ```ruby def find_with_ids(ids, cast) expects_array = ids.first.is_a?(Array) return ids.first if expects_array...
rake_support is wack: should require SolrWrapper, FcrepoWrapper, be a Module (or helper, or tasks)
The file is just a bunch of methods, not a Class or Module. It invokes `SolrWrapper` and `FcrepoWrapper` without requiring those gems. https://github.com/projecthydra/active_fedora/blob/v11.0.1/lib/active_fedora/rake_support.rb#L17-L32 It also includes a boolean conditional based...
`ActiveFedora::IndexingService#generate_solr_document` yields the `solr_doc` to a block, if given one, [here](https://github.com/projecthydra/active_fedora/blob/da5130fa6ab622ade514a3a76293b6a4723abd53/lib/active_fedora/indexing_service.rb#L30-L45). Specifically, it yields the doc AFTER adding all its data. So far, good enough. The problem is that this...
Currently testing Ruby 2.1 and Ruby 2.2.1 each with **one** 4.x version of rails, the **same** _unreleased_ version of rsolr and essentially unspecified individual versions of Solr and Fedora. This...
I went back and tried to rerun previously successful Travis builds on older branches. They are all broken. Failures include: - `5.x` - `6.4-stable` - `6.5-stable` - `6.6-stable` - `6-7-stable`...