Joe Atzberger

Results 35 issues of Joe Atzberger

There are likely hundreds of examples, but we have a problem every time module code invokes a method (or attribute, class variable, etc.) that: - it has no certainty even...

Refactor

Not sure which repo state is represented by the marc4j-2.5.1.beta.jar file. Repo should have a corresponding git tag designating that snapshot in time. After creating one, be sure to do...

Since golicense is distributed in binary form, it would help debugging and differentiation for it to respond to `-version` in the conventional way. While `go version -m -v /path/to/golicense` can...

[2012-11-01T03:02:10+00:00] INFO: Storing updated cookbooks/user/attributes/default.rb in the cache. # # Recipe Compile Error in /var/chef/cache/cookbooks/user/attributes/default.rb ## IndexError string not matched ## Cookbook Trace: /var/chef/cache/cookbooks/user/attributes/default.rb:24:in `[]=' /var/chef/cache/cookbooks/user/attributes/default.rb:24:in`from_file' ## Relevant File Content:...

Increase bus factor. Options include: projecthydra-labs, code4lib, sul-dlss, etc.

Dependencies aren't compatible anymore on half of the build environments, e.g.: ``` NoMethodError: undefined method `last_comment' for # /home/travis/.rvm/gems/ruby-2.3.0/gems/rspec-core-2.99.2/lib/rspec/core/rake_task.rb:143:in `initialize' /home/travis/build/mbklein/equivalent-xml/Rakefile:17:in `new' /home/travis/build/mbklein/equivalent-xml/Rakefile:17:in `' /home/travis/.rvm/gems/ruby-2.3.0/gems/rake-12.3.0/exe/rake:27:in `' /home/travis/.rvm/gems/ruby-2.3.0/bin/ruby_executable_hooks:15:in `eval' /home/travis/.rvm/gems/ruby-2.3.0/bin/ruby_executable_hooks:15:in `'...

Serious copy-pasta, 90+% similarity: - https://github.com/samvera/hydra-works/blob/master/lib/hydra/works/services/add_file_to_file_set.rb - https://github.com/samvera/hydra-works/blob/master/lib/hydra/works/services/add_external_file_to_file_set.rb Also both are classes, but each defines two other classes inside the outer one. That is something we conventionally do in module...

Two monkey patches, actually: ``` ruby ActiveFedora::QueryMethods.module_eval do extend ActiveSupport::Concern included do include Hydra::AccessControlsEnforcement end def accessible_by(ability, action = :index) permission_types = case action when :index then [:discover, :read, :edit]...

How does a module with no ancestors call `super` in a method? (Multiple methods.) Example: https://github.com/projecthydra/hydra-head/blob/master/hydra-access-controls/lib/hydra/policy_aware_access_controls_enforcement.rb#L9 I know this recurs generally in the Hydra stack but it is bad design....

Bug