Andrew Scott

Results 157 comments of Andrew Scott

Render hooks are not executed on the server: https://angular.io/guide/ssr#authoring-server-compatible-components I was surprised to find that this wasn’t documented directly on the hook api docs as well. This should be fixed.

One additional note is that render hooks execute outside the Angular zone in the browser so the setTimeout will not trigger change detection.

Ah, actually I just found the part about only executing on the browser: https://github.com/angular/angular/blob/1ee9f32621f6d72e8038a08f5ad4a0cfe8bd6a13/packages/core/src/render3/after_render_hooks.ts#L262-L264 Removing help wanted label. The documentation doesn't mention that these are run outside the zone but...

This PR was merged into the repository by commit fedeaac8ba85002e34dbd6ffa682d7483d39b5fd.

This PR was merged into the repository by commit 28fb385eec03f64b624a9b67d6d8147b6872a939.

This PR was merged into the repository by commit 367b3ee6e99d7b2669e7f7ded55d8eaab0ba4752.

Adding blocked and TGP label. This broke internal builds because the native `search` is not a void element but existing components with the same selector might be used in templates...

> I had the feeling that the preferred way of redirecting was to return a UrlTree from the guard rather than imperatively navigating from the guard. Yes, redirects should generally...

The default value applies when no value is bound in the template. The implementation of input binding specifically sets any not present values to `undefined`. This avoids the situation where...

Reopening and labeling as a documentation issue. The API docs should call this out and also mention that `{required: true}` does not apply in this situation either.