Andrew Scott
Andrew Scott
Closing - there's no indication that this is a change that needs to be made at this time. If this becomes an actual problem that applications run into, we can...
blocked by https://github.com/angular/angular/pull/52455
> eagerly awaiting this now that the blocker is resolved, will it also fix the tooltip positioning in zoneless yes, this would fix the tooltip positioning in Zoneless. Note that...
> LGTM but I suspect that this will be pretty breaking during the TGP. Yea, definitely a concern I have as well.
Closing - after more investigation, the issue with focus is actually the focus trap, not the dialog promise here. `afterNextRender` should be added to the focus trap instead of the...
Reopening - This is somewhat the responsibility of the dialog and I think the focus-trap is a separate issue. The dialog has control over what APIs in the focus trap...
@crisbeto PTAL - I had to update the fix to put the `ChangeDetectorRef` on the dialog container itself because the title also modifies the queue in its `ngOnDestroy` and I...
caretaker note: I'm not sure how merging is handled when changes affect the legacy components internally. This change will require deleting the `_changeDetectorRef` from the `MatLegacyDialogContainer` since it's now in...
[Green TGP](https://fusion2.corp.google.com/presubmit/593841803/OCL:593841803:BASE:594317227:1703802870566:46ed1c6b/targets) with local change mentioned above (remove `_changeDetectorRef` from constructor of ...legacy-dialog/dialog-container.ts)
The goal is to have this addressed in V16. This is a difficult change to make because it requires completely rewriting parts of the URL creation and matching logic in...