Andrew Scott

Results 157 comments of Andrew Scott

@SchnWalter That's right, the idea for this feature would be to solve it through #27148. That generally makes this a duplicate but we're keeping it open for discoverability.

@nebkat Appreciate the detailed research here. I don't have the full history either, but I've discovered information that I believe to be true after inheriting ownership of the Router code...

Closing as generally not relevant anymore. @nebkat outlined quite a few changes that improved things since this was reported and contributed https://github.com/angular/angular/pull/48033 to shore up yet another issue. There are...

@alan-agius4 Can you provide some more details? This will throw an error in the browser. Why is the prerender not throwing?

I updated the router bundle in `node_modules` so the `scheduleNavigation` always just returns `Promise.reject('lkajsdflkjasdf')` and there is no error in the prerender. If I update the function to `throw 'some...

I don't know why the rejected promise is getting swallowed during prerendering. You can at least solve this in user-space by always logging the router errors to the console: ```...

Note: This is related to the internal issue [b/234604699](http://b/234604699). These issues are related but actually solve distinctly separate parts of the parsing. The solution here parses `=` in the segment...

@DW8Reaper I think essentially you just need to update `const valueMatch = matchMatrixParamSegments(this.remaining);` to be `const valueMatch = matchSegments(this.remaining);`. We can leave this open and give you the credit for...

> Cool I can do that, not sure if you saw my other comment @atscott about it not preserving the = when the page navigation completes instead it the %...

@DW8Reaper No, I'm just waiting to hear back about the results from the internal experiment.