Results 13 comments of Adrian Torchiana

That would be wonderful, thank you for offering. The app has already been translated into German -- I'll post some links here showing how that was done: - https://github.com/atorch/probability_puzzles/blob/master/app/src/main/res/values/strings.xml original...

https://developer.android.com/training/basics/supporting-devices/languages is also helpful: > Some users choose a language that uses right-to-left (RTL) scripts, such as Arabic or Hebrew, for their UI locale. There's a lot of info there...

And here's the pull request that added the German translation: https://github.com/atorch/probability_puzzles/pull/7. Notice that the MR is mainly adding the [values-de/strings.xml](https://github.com/atorch/probability_puzzles/blob/master/app/src/main/res/values-de/strings.xml) file.

Yes, you'll want to fork and then open a PR into this repo (from the feature branch in your repo to the main/master branch in this repo). See https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork

If you click on the link to the [German translation PR](https://github.com/atorch/probability_puzzles/pull/7), you'll see it says [atorch](https://github.com/atorch) merged 4 commits into [atorch:master](https://github.com/atorch/probability_puzzles) from [rillig:master](https://github.com/rillig/probability_puzzles) -- you'll do something very similar for...

Good question! There are a few ways to make sure everything is working correctly: When you open an MR like https://github.com/atorch/probability_puzzles/pull/25 (note that I changed the target branch to https://github.com/atorch/probability_puzzles/tree/hebrew...

@Roymaor01 let's see whether we get a green or red check mark when the github check tries to build the app in https://github.com/Roymaor01/probability_puzzles/pull/1 You'll have to click approve in order...

That would be wonderful! I need to read up on how to make a single app with multiple languages, but that sounds by far like the better option (relative to...

Hey, I'm here! I see https://github.com/atorch/probability_puzzles/pull/7, I'll give it a try on my phone when I have some free time

@N0wan you should now see https://github.com/atorch/probability_puzzles/blob/master/app/src/main/res/values/strings.xml and https://github.com/atorch/probability_puzzles/blob/master/app/src/main/res/values-de/strings.xml when you pull down the latest master