probability_puzzles icon indicating copy to clipboard operation
probability_puzzles copied to clipboard

French translation

Open N0wan opened this issue 5 years ago • 12 comments

Hey there !

Would you be interested by a translation in French language ?

N0wan avatar Jun 03 '20 23:06 N0wan

I can easily translate all the strings. But would you provide a multi-language app (needing the code to be adapted) ? The other solution being to provide one app per language (less good).

N0wan avatar Jun 04 '20 04:06 N0wan

That would be wonderful! I need to read up on how to make a single app with multiple languages, but that sounds by far like the better option (relative to multiple single-language apps).

atorch avatar Jun 04 '20 21:06 atorch

Yes indeed. So, when you'll modify the source code, or add new features, you'll only have to do it once. Actually that will be my first contribution to a multi-language app... sounds interesting ! Btw, I'm a fan of your app !

N0wan avatar Jun 05 '20 06:06 N0wan

See https://github.com/atorch/probability_puzzles/pull/7, where I am adding the German translation. The main part is really only adding a file values-de/strings.xml containing the translated strings.

Some of the images need to be translated as well as they contain text. I left that for later, but I still have the list for translating the images in my e-mail archive.

rillig avatar Jan 29 '22 18:01 rillig

For sure, I can do that. But just to be sure, why can't I find your folder values-de in any branch ?

N0wan avatar Feb 04 '22 10:02 N0wan

The German translation is in my fork over at https://github.com/rillig/probability_puzzles, in the master branch. Before starting to translate, you might ask @atorch whether he still wants to release a new version of the app including the translations, just to make sure you don't waste time doing the translation for nothing.

rillig avatar Feb 04 '22 11:02 rillig

Thanks, I'll do so

N0wan avatar Feb 08 '22 19:02 N0wan

Actually, I don't know how to contact him... ?

N0wan avatar Feb 08 '22 19:02 N0wan

Hey, I'm here! I see https://github.com/atorch/probability_puzzles/pull/7, I'll give it a try on my phone when I have some free time

atorch avatar Feb 09 '22 01:02 atorch

@N0wan you should now see https://github.com/atorch/probability_puzzles/blob/master/app/src/main/res/values/strings.xml and https://github.com/atorch/probability_puzzles/blob/master/app/src/main/res/values-de/strings.xml when you pull down the latest master

atorch avatar Feb 09 '22 06:02 atorch

Hello, I could do Greek and Spanish translations.

ghost avatar Aug 11 '22 15:08 ghost

@esodigoyo that would be great, thank you for offering! Have a look at https://github.com/atorch/probability_puzzles/issues/20#issuecomment-1199784463 and https://github.com/atorch/probability_puzzles/blob/master/app/src/main/res/values-de/strings.xml and https://developer.android.com/guide/topics/resources/localization#creating-alternatives to see how translations work. Let me know if you need additional tips! This issue is about a French translation specifically, so let's open a separate issue for Greek and Spanish in the event that you have any questions specific to creating a values.xml file for those languages.

atorch avatar Aug 11 '22 20:08 atorch