Andrew Taylor

Results 224 comments of Andrew Taylor

@benoitchantre summary of the discussion over on wp-cli is that minified files are not supported for translations. > ideally you would run the string extraction on the source files in...

> JS files need to be unminified before we run `wp i18n make-pot` > If these conditions are met, `wp i18n make-json` will generate `.json` files with the correct file...

> Do you have some time to update this PR? @benoitchantre not currently. I have been very busy with work and personal life recently 😞

> Ideally, text replacement should be done on .po files, then .mo files should be generated from .po files in the bundle. What do you think of text replacement being...

I'm not sure I follow. Rather than trying to string replace the translation files generated against the WP Rig dev theme I want to create the production PHP files, run...

I wonder if we should use [the wp-cli `i18n make-pot` command](https://developer.wordpress.org/cli/commands/i18n/make-pot/) here as it handles not just PHP but JS as well. The gulp translation tasks can call `wp i18n...

@benoitchantre do you think it is okay to run string translation on the `.pot` file generated from the dev (wp-rig) files for production OR would it be better to generate...

Perhaps this issue will morph into creating a `wp-config.pantheon.php` and conditionally requiring that from `wp-config.php`

@westonruter agreed. The current nag message is not filterable so I had to remove it and replace with our own. See #126

The DLC with the new skill trees is live. @seigler hopefully the code here looks okay. Let me know if you would like to see any revisions