WordPress icon indicating copy to clipboard operation
WordPress copied to clipboard

Test For WordPress Coding Standards

Open ataylorme opened this issue 5 years ago • 4 comments

wp-config.php and wp-content/mu-plugins/pantheon should adhere to WordPress coding standards. An automated test should also run on every pull request.

Related: #179

ataylorme avatar May 31 '19 15:05 ataylorme

Coding standards are cool, but I am concerned about how many merge conflicts we might cause in downstream repositories if we reformatted wp-config.php.

greg-1-anderson avatar May 31 '19 15:05 greg-1-anderson

There is an increased possibility for merge conflicts the moment anyone edits this file because it does not implicitly follow any coding standard. I routinely add at least four customizations that cannot be done anywhere else.

dylanjameswagner avatar May 31 '19 18:05 dylanjameswagner

Perhaps this issue will morph into creating a wp-config.pantheon.php and conditionally requiring that from wp-config.php

ataylorme avatar May 31 '19 19:05 ataylorme

Yes, Pantheon made a mistake a long time ago and did not set up wp-config.php to be particularly maintainable. The result is that Pantheon users have to modify wp-config.php, so any time we make modifications to it, we risk creating a lot of merge conflicts.

Fixing this problem will cause a lot of merge conflicts, but perhaps it will be worth it in the long run.

greg-1-anderson avatar May 31 '19 21:05 greg-1-anderson