Atanas Stoyanov

Results 71 comments of Atanas Stoyanov

Hi, thanks for the work and looking forward to v2. I am building a documentation system using mdx: https://component-controls.com/tutorial/mdx-documentation

Hi, I have been working on a documentation project that can be of interest here and would love to get some feedback. docz migration article: https://component-controls.com/blogs/docz-migration git: https://github.com/ccontrols/component-controls Btw, I...

@ericsoderberghp @ShimiSun if a project is not set up for tree shaking, `grommet` itself forces importing all icons from `grommet-icons`. As the screenshot above suggests, both `grommet` and `grommet-icons` are...

Just to make it clear - even when @shai32 correctly used `import { AddCircle } from 'grommet-icons/icons/AddCircle';`, the full grommet-icons is being imported because of the above issues in `grommet`...

@ShimiSun - would you also consider adding some documentation on the grommet usage without tree shaking set up?

Possibly in the section ‘Start coding’ on the home page have a note on importing components from their own folder if tree shaking is not enabled with a small code...

Yes, that would be good too, just someplace to point users to

Its almost correct - v2 had what is called webpack 4?tree shaking support by having the setting sideEffects turned off in package.json. Thats about it, othing special. The problem arose...

The little bit of documentation that i thought should be on the grommet site is this clarification on imports https://grommet-nextjs.herokuapp.com/get-started Clearly the original posters are also importing the entire grommet...

@davidmccabe - that would be great - pls post any updates when you have an ETA. Thanks again.