Alfonso Subiotto Marqués

Results 54 comments of Alfonso Subiotto Marqués

Planning on taking this on. I think adding some benchmarks to FrostDB that represent the cloud OKRs would be pretty useful to get some less noisy benchmarks.

Hi @Pryz, definitely happy to take a stab at it since it should be a good way to learn more about the parquet library (thanks for writing + maintaining btw)....

I'm having the same issue cc @rafiss

My intuition is that for some reason https://github.com/polarsignals/frostdb/blob/beada053c7d916e9681b93905eaa49e423af1b88/query/physicalplan/physicalplan.go#L111 is returning a non-nil zero-length schema. I'm not sure how this is possible since we iterate over all the row groups to...

In (https://github.com/polarsignals/frostdb/pull/195), I added a protection for a zero-length schema so that we don't panic and instead return an error. We should still figure out why this is happening.

Added a fix to https://github.com/polarsignals/frostdb/pull/195 for the old behavior of emitting zero rows in the case of an empty schema. I now see how it can happen (empty table, context...

I think that's a great idea @maxbrunet, thanks for the suggestion.

> I think overall I'm fine with this change, my only question is if we considered instead of doing a sweep, we do a notify? Where after adding to a...