Alfonso Subiotto Marqués
Alfonso Subiotto Marqués
We should be able to repro easily with dst and manually panicking if we try to log to a NopWAL (as discussed in the meeting). Will leave this on the...
The reason I added this check was that I was seeing getfield fail at execution time unexpectedly because the table schema (merged schema over all files) does have the field...
Ahh, that makes sense. We already do pushdown checks in the opener against the file schema, so `can_be_pushed_down` should return true in `try_pushdown_filters` at the source level against the table...
I had a more general message on discord: > One other thing I'd like to add is that IIRC, if the file source returns that it cannot push down a...
cc @robert3005
Thanks for the reviews. I will address comments and CI on Monday.
I'm not sure how to best fix CI. The core issue is that the consistency tests call out to compute kernels that sometimes use `ArrayRef::from_arrow` (https://github.com/vortex-data/vortex/blob/d578fe02e147ebef2f6e49596a33ca168ec2425c/vortex-array/src/compute/mask.rs#L134) which isn't implemented for...
Thanks! No problem, this behavior is needed for us so I don't mind waiting to merge this and running off a fork in the meantime.
@robert3005 with the recent IO changes, this change will soon be the only thing requiring us to use a fork of vortex. Is there anything I can do to help...
Making some progress thanks to @onursatici's recent changes 🥳 Seems like there's now a failure on tpch queries probably due to the preferred encoding of string dictionaries resolving to dict....