hana icon indicating copy to clipboard operation
hana copied to clipboard

Published 20 hours ago • verified publisher icon tenderlove

Add railtie

Open guillec opened this issue 11 years ago • 5 comments

  • Fixed README example
  • Add railtie so if the gem is added to a rails project it registers a mime type to respond to application/json-patch+json

Based on conversation with @steveklabnik https://github.com/steveklabnik/merge_patch_test/pull/2#issuecomment-18464734

guillec avatar May 28 '13 04:05 guillec

Will do

guillec avatar Aug 08 '13 13:08 guillec

@guillec ! Any chance you can update this? :wink:

steveklabnik avatar Jun 09 '14 03:06 steveklabnik

@steveklabnik sorry :( yeah I will get do it this weekend.

On Sun, Jun 8, 2014 at 11:01 PM, Steve Klabnik [email protected] wrote:

@guillec https://github.com/guillec ! Any chance you can update this? [image: :wink:]

— Reply to this email directly or view it on GitHub https://github.com/tenderlove/hana/pull/3#issuecomment-45457694.

guillec avatar Jun 11 '14 13:06 guillec

@tenderlove @steveklabnik updated per your suggestion.

guillec avatar Jun 16 '14 13:06 guillec

Why can't this be in another gem? I don't think it's a good practice to include Rails stuff everywhere.

For example, I plan to use this gem in a project. It's super simple, just one file, specific for the purpose of json-patch. With this PR, I'll have more code around which I won't use. I know it doesn't really affect the code if I don't require it, but it just feels messy to throw all code in a single gem. Maybe hana-rails would be better.

asterite avatar Jan 24 '18 21:01 asterite