Assaf Admi
Assaf Admi
This PR adds new test cases for kubevirt alert definitions. We expect to see `summary`, `runbook_url`,`severity`, `kubernetes_operator_part_of` and `kubernetes_operator_component` for each alert. Those fields must not be empty and some...
This PR updates recording rules names which don't meet the naming convention. Recording rules should follow the same naming conventions as metrics (i.e. have a `kubevirt_` prefix). These are the...
**Description of the change:** This PR adds to the sample `memcached-operator` (`testdata/go/v3/memcached-operator`) a metric named `memcached_number_of_replicas_reconcile_count_total` as part of a new `monitoring` directory. This metric counts the number of times...
Signed-off-by: assafad **Description of the change:** This PR adds a test for the sample memcached-operator. The test validates that the new operator metric `memcached_deployment_size_undesired_count_total` exists and works as expected. **Motivation...
**What this PR does / why we need it:** Create `tests/libmonitoring` library and move monitoring related tests utils to this lib. In addition, convert the inline function `getKubevirtVMMetricsFunc()` from `tests/utils.go`...
### What this PR does Apply the following linters: - [monitoringlinter](https://github.com/kubevirt/monitoring/tree/main/monitoringlinter) that was implemented in https://github.com/kubevirt/monitoring/pull/221, and was designed to enforce https://github.com/kubevirt/community/pull/219. This linter ensures that all monitoring-related practices are...
### What this PR does - Move `NotDeleted()` to `/libreplicaset` (since it's used only by replicaset test), rename it to `FilterNotDeletedVMIs()` and remove its [named returned value](https://go.dev/tour/basics/7). - Move `NotDeletedVMs()`...
### What this PR does Add `kubevirt_vmi_last_connection_timestamp_seconds` metric, which reports the last connection timestamp per VMI. Connections covered: console, vnc, usbredir, portforward and SSH. Fixes https://issues.redhat.com/browse/CNV-14659 ### Why we need...
### What this PR does Before this PR: pod related functions are in tests/utils.go. After this PR: pod related functions moved to libpod. /sig code-quality ### Checklist This checklist is...
### What this PR does Before this PR: The underlying recording rule for `LowReadyVirtOperatorsCount` alert - `kubevirt_virt_operator_ready` which reports the number of ready virt-operator pods, is based on `kubevirt_virt_operator_ready_status` metric,...