operator-sdk
operator-sdk copied to clipboard
operator-framework
Add testing for the sample memcached-operator metric
Signed-off-by: assafad [email protected]
Description of the change:
This PR adds a test for the sample memcached-operator. The test validates that the new operator metric memcached_deployment_size_undesired_count_total exists and works as expected.
Motivation for the change: We would like to implement observability concepts for the memcahced-operator, in order to have the operator in Deep Insights capability level. Then, we may use it as a reference in an observability best-practices tutorial in Operator-SDK documentation.
Checklist
If the pull request includes user-facing changes, extra documentation is required:
- [ ] Add a new changelog fragment in
changelog/fragments(seechangelog/fragments/00-template.yaml) - [ ] Add or update relevant sections of the docs website in
website/content/en/docs
Hi @everettraven, could we please move ahead with this PR? It was on hold waiting for Ginkgo v2, and was approved by @camilamacedo86.
@assafad: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
In response to this:
/retest
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@assafad: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
In response to this:
/retest
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@assafad: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.
In response to this:
/retest
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@everettraven Thank you for reviewing this PR. Anything else we miss in order to get it merged?