Anton Korobeynikov comments

Results 792 comments of


                                            Anton Korobeynikov

Load layout via command line?

This is not currently implemented. The only way to load layout is from the UI

Bandage-NG supports various options for specifying depths from GFA: https://github.com/asl/BandageNG/wiki/Custom-GFA-tags#node-depths As GFA tags are case sensitive, `dp` and `DP` technically are different tags.

Adding depth data to a graph

> Seeing as unicycler produced assemblies with `dp`, could you add that as a depth option? Yes, sure.

Adding depth data to a graph

Fixed in https://github.com/asl/BandageNG/commit/a57ef610054560c49b1036c1f81c0bdf70af0df2

Add cmake-based build system

I have not updated readme's and github actions for new cmake system – let me know if you would like me to do this.

Set type for LAnd and LOr to be Type_Boolean if unknown.

Hrm, interesting. I'd expect types to be unique / singletons, what is the point having multiple `Type_Boolean` or `Type_Unknown`?

Set type for LAnd and LOr to be Type_Boolean if unknown.

> `new IR::Type_Boolean()`. We could make the allocator operators for these classes private. I think so. I might be missing something, but I do not see a point of having...

Set type for LAnd and LOr to be Type_Boolean if unknown.

> LAnd,LOr may have simply be an oversight. Yes. For "underlying issue" I mean allowing different `Type_Boolean` instances, etc.

Set type for LAnd and LOr to be Type_Boolean if unknown.

> I would argue that the program should not assume there will be only one. It would be quite weird if some type representations were fully uniqued in this way,...

Set type for LAnd and LOr to be Type_Boolean if unknown.

> In particular if you're using pointer comparison to determine equality. That's the key question. What it going from the language perspective? And what is going from the IR perspective?...