Anshul Singhvi comments

Results 1165 comments of


                                            Anshul Singhvi

Standard `makedocs` call fails if you aren't in a git repo

Why should this error, is more the question to me. A warning seems sufficient?

Standard `makedocs` call fails if you aren't in a git repo

Just from a file? But not in a git repo. This was specifically to create and display documentation locally.

Standard `makedocs` call fails if you aren't in a git repo

Can we at least have the error occur only in CI, then?

Standard `makedocs` call fails if you aren't in a git repo

From discussion we settled on having something like `repo = Documenter.OptionalRepo()` that will trigger ignoring this behaviour if not in a repo. Closing this in favour of that kind of...

Don't use the Module(...) constructor to create a module

Yeah, not sure why the tests failed, but they magically turned green on the last commit. Might have been an intermittent thing, we'll see now I suppose

Don't use the Module(...) constructor to create a module

Ah no! I thought that would revert the commit, not the file 😅

Don't use the Module(...) constructor to create a module

Hmm, it looks like wrapping here somehow changed printing for errors and vectors? Maybe it's the module declaration bringing in Base? A lot of the errors seem fine to me,...

Don't use the Module(...) constructor to create a module

Ah interesting! But yeah I would not have expected that to be the case, especially since we are eval'ing in to the module with `invokelatest` (at least I think we...

Don't use the Module(...) constructor to create a module

So it turns out we were in fact _not_ using invokelatest, let's see if that helps any in CI. I noticed you added the changes from #2804 here as well,...

Don't use the Module(...) constructor to create a module

Awesome! Looks like all CI is passing with that change. Since the invokelatest was reverted I'd say this is ready to go!