Anshul Singhvi comments

Results 1165 comments of


                                            Anshul Singhvi

Print of large nested geometries is slow

Oh interesting, it's a wrapper around another polygon type. Yeah in that case I don't think we do the compressed printing - but maybe we should!

[S2Geography] New recipe

Hey @fingolfin, thanks for the ping! I marked this as ready for review and am re-running CI now.

[S2Geography] New recipe

Somehow it doesn't let me merge online, so I will do that locally tomorrow

no geometrycolumn keyword in write

it should be noted that geojson only allows "geometry" to be the name. nevertheless we should provide a kwarg for consistency and error/warn if it is not `:geometry`.

make Extents a weakdep

Any reason not to merge?

Complex Recipes for facets etc

That seems broadly reasonable to me (looked over the code but have not yet tested it)

Allow `hist` with an empty list

@Moelf any objections / better ideas?

Allow `hist` with an empty list

Thanks @ffreyer!

Define crstrait if available

True, but that restricts people who are forced onto e.g. v1.2 of GeoInterface for unrelated reasons from getting any updated version of GeoJSON, so this seemed a bit more broadly...

Define crstrait if available

BTW, https://github.com/JuliaGeo/GeoJSON.jl/pull/99 fixes CI (but nightly fails on type inference for some other reason)