Ashwin P Chandran

Results 235 comments of Ashwin P Chandran

@noCharger Can we keep the diff limited to just the change? I know it can be tempting (or just an accident) to push in a bunch of other linting fixes...

I like this idea but i'm not sure if we want to make it a workflow. An incorrect lockfile is an indication that the lock file is outdated and should...

Not really. You simply need to add the flag `--no-verify` or `-n`

@joshuarrrr yeah there is a functional test we plan on adding for this flow.

> > Now that we have some test coverage for saving and loading (thanks!), we should also include unit tests for this flow, particularly because there are five separate user...

Hey @pjfitzgibbons, thanks for addressing most of the comments. I dont see any changes since my latest review though. The 3 remaining callouts I had for the PR are: 1....

@jkdll All OpenSearch Dashboard objects (dashboards, Visualizations and Tenants) are stored as documents on the OpenSearch cluster using the `.kibana` index. e.g. ```json { "_index" : ".kibana_1", "_id" : "visualization:37cc8650-b882-11e8-a6d9-e546fe2bba5f",...

@kilitr Tenants are a concept of the security plugin. I'll let someone from @opensearch-project/security answer that. But from what i know, each tenant is just a namespaced `.kibana` index. e.g....

@kgcreative @btzeng do we need to update the VisBuilder Logo since the old one was created to reflect the name "Drag and Drop"?

@AMoo-Miki Can we close this then and reopen it when we have time to prioritize this?