OpenSearch-Dashboards icon indicating copy to clipboard operation
OpenSearch-Dashboards copied to clipboard

Published 20 hours ago • verified publisher icon opensearch-project

[Feature] Dashboards List Extensibility

Open pjfitzgibbons opened this issue 2 years ago • 4 comments

Description

Extend OSD Dashboard List to allow other plugins to supply their own list of "dashboards" to be appended to the OSD Dashboard List.

"Edit" column on Dashboard List availability is set per-row, dependent upon presence of editUrl value on each input row.

Screen Shot 2022-08-23 at 2 37 40 PM

Issues WIP

[FEATURE] Integrate Observability Panels/Apps lists into OpenSearch-Dashboards main List View

Related PR

Observability Plugin : [WIP] [FEATURE] Integrate Dashboards/Observability

Check List

  • [ ] New functionality includes testing.
    • [ ] All tests pass
      • [ ] yarn test:jest
      • [ ] yarn test:jest_integration
      • [ ] yarn test:ftr
  • [ ] New functionality has been documented.
  • [ ] Commits are signed per the DCO using --signoff

pjfitzgibbons avatar Aug 16 '22 21:08 pjfitzgibbons

Hey @pjfitzgibbons, thanks for addressing most of the comments. I dont see any changes since my latest review though. The 3 remaining callouts I had for the PR are:

  1. There still seems to be a duplicate interface for DashboardListItem and DashboardListItems
  2. Tests for the new functionality (You can just add to the existing functional tests for the component)
  3. Fixing the existing Functional tests that are breaking in the CI runner

ashwin-pc avatar Aug 27 '22 01:08 ashwin-pc

Can we get an update?

seanneumann avatar Sep 26 '22 20:09 seanneumann

Will have a new commit to post on Tue. Sep 27

Thanks and Kindest Regards, Peter Fitzgibbons (224) 307-9689

On Mon, Sep 26, 2022 at 1:52 PM Sean Neumann @.***> wrote:

Can we get an update?

— Reply to this email directly, view it on GitHub https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2149#issuecomment-1258620154, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAACYNR3CB4OFIQUBFFCHZLWAIEKLANCNFSM56XLMXOA . You are receiving this because you were mentioned.Message ID: @.*** com>

pjfitzgibbons avatar Sep 26 '22 22:09 pjfitzgibbons

@pjfitzgibbons Just following up to see if you're able to update the PR an resolve conflicts or remove the yarn.lock file.

joshuarrrr avatar Oct 04 '22 18:10 joshuarrrr

@pjfitzgibbons Should this PR be closed in favor of #2670, or are you still working on this? For now, I'm going to set it to draft since it's stale.

joshuarrrr avatar Nov 14 '22 19:11 joshuarrrr