Ashwin P Chandran

Results 235 comments of Ashwin P Chandran

@sipopo Thanks for the change, it looks good. The changelog check is failing because we introduced a changelog requirement for all PR's. Its a simple requirement. You just need to...

You can add the title of the original issue ``` * Ability to start OS Dashboards with a newer and compatible nodejs version ([#2091](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2091)) ``` You can add this under...

@kavilla @joshuarrrr Can you take a look at this? We can fix the conflict ourselves in github without dismissing the approvals.

@kavilla thanks for the clarity. My biggest concern with this feature in Dashboards is how its integrated with another similar but purely dashboard feature "`Saved Search`". Judging by the design...

@kgcreative That makes sense. From that perspective the difference between "Saved searches" and "PIT" is clearer (and yes, the name could be better). But i'm still not very happy with...

Talked to @kgcreative offline. I think what we need here are we need user stories. What are the user problems we are trying to solve. My personal opinion is that...

closing the PR since #6065 has been merged. Thats the same PR, just that the toggle has moved from the yaml config to the advanced settings.

I was following your test instructions. Inserting a test workspace did not do anything. If i inserted a workspace called `foo` but added `/w/bar` to the URL. `/w/bar` persisted. Deleting...

> @ashwin-pc I think the major concern left is the one that we may introduce an in-direct dependency in core to plugin ([#6060 (comment)](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/6060#discussion_r1517106496)) , For now there are two...

@wanglam How can i validate this change? Can ou add testing instructions to the PR description? It makes reviewing PR's a lot easier