Ashish Dhingra

Results 301 comments of Ashish Dhingra

Might be related to https://github.com/aws/aws-lambda-dotnet/pull/1203.

Hi @wahmedswl, Good morning. Thanks for the feature request. I'm not sure if this feature is feasible but I will review it with the team. While I cannot commit on...

@Dreamescaper Thanks for submitting feature request. Please advise on how you came up with the JSON format of the log output. Did you use Serilog structured logging as reference?

Needs review with the team.

@ElectricVampire Assuming you are using [S3Event](https://github.com/aws/aws-lambda-dotnet/blob/master/Libraries/src/Amazon.Lambda.S3Events/S3Event.cs) class in your Lambda, the change you are proposing could be a breaking change for existing customers. `S3Event` class inherits from [Amazon.S3.Util. S3EventNotification](https://github.com/aws/aws-sdk-net/blob/ac600c168cbbfac23d5f2590e9b3b2eb8dbb7a8f/sdk/src/Services/S3/Custom/Util/S3EventNotification.cs#L15) from...

Need to check the behavior in AWS SDK for .NET and make it consistent here.

Probable fix is to remove condition `type.FullName.StartsWith("Amazon.Lambda.CloudWatchEvents.")` in the code https://github.com/aws/aws-lambda-dotnet/blob/c7cb94721a20efdec9cc98aac7e899848d1f415f/Libraries/src/Amazon.Lambda.Serialization.Json/AwsResolver.cs#L127 Needs review from development team.

Reproducible. Unsure if the Annotations Framework could be used with simple Lambda functions. The Readme at https://github.com/aws/aws-lambda-dotnet/tree/master/Libraries/src/Amazon.Lambda.Annotations specifies use of `HttpApi` or `RestApi` for Annotations serverless application. Needs review with...

@Dreamescaper Thanks for submitting feature request. While we could not commit on the timeline by which this request could be reviewed, feel free to contribute a PR that could be...