Erin
What game is this with?
This needs a description with the reason for the change.
This is a reasonable request and the change looks good, but I'm a little worried about the interaction with Handle permissions. I'm not sure the existing Menu handle type restrictions...
I think that is probably the easiest and safest route - as long as we avoid this function leaking them the open permissions aren't really a problem. We could instead...
Got two potential solutions for the bug here (in each commit), one on the C++ side that is more generic but a slightly hairy implementation (I think only TF2 can...
Ah, I hadn't spotted that any other plugins were using SetNextMap - yeah, probably best to take both of these then (they do work well together). The core changes will...
This was discussed on Discord before it was opened, I'm pretty confident the behaviour here is a bug - `ReadString` takes separate `max_size` and `read_count` params for a reason, it...
> `ReadString` takes separate `max_size` and `read_count` params for a reason, it makes no sense for it stop reading before `read_count` is reached. This was all very wrong, I missed...
This was an intentional trade off, the reasoning is given in the linked PR. We could do both, but that would result in differing behaviour between Windows and Linux which...
This is the crashing form of #778 - which is clientprefs losing it's database config reference and passing garbage into the DBI layer. It is mentioned as an aside in...