James Titcumb
James Titcumb
PRs with tests are more than welcome! I really do want to find time to update this, fix the weird janky cases to have some kind of expected consistency. Also...
At the moment, can't merge this as it would be a BC break (hence why that test case exists). Yes, it's stupid behaviour but some may rely on it, unfortunately...
Currently, to find time to refactor for better quality, more tests, fix the stupid things that don't make sense and make a minimum PHP 7.1 or 7.2 probably :+1:
This is a BC break (even if it's preferable), and we have not nearly enough unit test coverage to explicitly show the breakages. Will need to think on this!
They rarely conform to specs, sadly! There's lots of edge cases taken into account, hence why we could really do with some more unit tests.
Note: tests showing this weird behaviour are commented with `@todo` now: https://github.com/asgrim/ofxparser/blob/master/tests/OfxParser/OfxTest.php#L40
As this is a BC break, I'm going to schedule this for 2.0.
Nice improvement, thank you @berosoboy - just a couple of changes please as above :)
Sorry for the delay on this one, there seems to be a conflict - could you take a look please and poke me when resolved? Thanks!
Hmm, not currently sure how to make this more clever regarding the various ways the OFXs are generated. Ideally, we need to conform to spec (we'd need to read up...